Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extensions in pack Buildpack downloader #1757

Merged
merged 7 commits into from
May 19, 2023
Merged

Add support for extensions in pack Buildpack downloader #1757

merged 7 commits into from
May 19, 2023

Conversation

itsdarshankumar
Copy link
Contributor

@itsdarshankumar itsdarshankumar commented May 10, 2023 •
edited
Loading

Summary

Adds feature to add packaged extensions while creating a builder

Output

image
image
image

Before

Used to throw SIGSEV

Related

Resolves #1684

@itsdarshankumar itsdarshankumar requested review from a team as code owners May 10, 2023 14:48
@itsdarshankumar itsdarshankumar marked this pull request as draft May 10, 2023 14:48
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 10, 2023
@github-actions github-actions bot added this to the 0.30.0 milestone May 10, 2023
@itsdarshankumar itsdarshankumar marked this pull request as ready for review May 11, 2023 18:18
@natalieparellano
Copy link
Member

Thank you @itsdarshankumar - this looks great! Would it be possible to add a test case to pkg/buildpack/downloader_test.go? Something along the lines of:

		when("package image lives in docker registry", func() {
			when("image key is provided", func()
				it("should succeed", func() {

The other tests in this context (for buildpacks) would probably be redundant for extensions.

@itsdarshankumar
Copy link
Contributor Author

Thank you @itsdarshankumar - this looks great! Would it be possible to add a test case to pkg/buildpack/downloader_test.go? Something along the lines of:

		when("package image lives in docker registry", func() {
			when("image key is provided", func()
				it("should succeed", func() {

The other tests in this context (for buildpacks) would probably be redundant for extensions.

sure, I'll add the test cases

natalieparellano
natalieparellano approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @itsdarshankumar! IMO Codecov is being too picky... this will really smooth out the experience of using extensions for end users!

jjbustamante
jjbustamante approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @itsdarshankumar !!!

@jkutner jkutner enabled auto-merge May 19, 2023 15:45
@jkutner jkutner merged commit aded316 into buildpacks:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

@jjbustamante jjbustamante jjbustamante approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.

pack buildpack downloader should support extension packages
4 participants
@itsdarshankumar @natalieparellano @jkutner @jjbustamante